Skip to content

Add durable startup memory context#4

Open
coe0718 wants to merge 3 commits intoghostwright:mainfrom
coe0718:startup-durable-context
Open

Add durable startup memory context#4
coe0718 wants to merge 3 commits intoghostwright:mainfrom
coe0718:startup-durable-context

Conversation

@coe0718
Copy link
Copy Markdown
Contributor

@coe0718 coe0718 commented Mar 31, 2026

Summary

Adds a small startup-only durable memory section for brand-new sessions so Phantom begins with a bit of long-term continuity before normal retrieval takes over.

What Changed

  • passes isNewSession from the runtime into the memory context builder on the first turn of a fresh session
  • adds a compact Durable Context section that only appears on new sessions
  • selects durable facts from the normal semantic recall using high confidence filtering
  • adds a metadata-ranked episodic recall pass for startup memories and deduplicates those memories from the normal sections
  • preserves stale low-signal episodic filtering from the current main branch during normal context injection
  • documents the new startup behavior in docs/memory.md

Why

This keeps the contribution focused on startup retrieval rather than adding a parallel memory system. It gives new sessions more continuity while staying aligned with the existing episodic + semantic + procedural memory design.

Testing

  • bash -lc 'export PATH="$HOME/.bun/bin:$PATH" && /home/coemedia/.bun/bin/bun test src/memory/__tests__/context-builder.test.ts'
  • bash -lc 'export PATH="$HOME/.bun/bin:$PATH" && /home/coemedia/.bun/bin/bun test'
  • /home/coemedia/.bun/bin/bun run typecheck
  • /home/coemedia/.bun/bin/bun run lint

Notes

  • Rebasing onto current main required carrying forward the startup-only durable context while preserving the newer stale-memory filtering already merged in context-builder.ts.

Copy link
Copy Markdown
Member

@mcheemaa mcheemaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2 just landed on main. Can you rebase this on main when you get a chance? Will review once it's updated.

@coe0718 coe0718 force-pushed the startup-durable-context branch from 7e9c3ba to 19e97aa Compare March 31, 2026 21:14
@coe0718
Copy link
Copy Markdown
Contributor Author

coe0718 commented Mar 31, 2026

Rebased

imonlinux added a commit to imonlinux/phantom that referenced this pull request Apr 24, 2026
Complete security review and implementation of fixes for Nextcloud Talk
integration based on comprehensive security audit findings.

HIGH PRIORITY fixes (security-critical):
- ghostwright#1: Implement replay attack protection with LRU cache (5-minute TTL)
- ghostwright#2: Add 64KB request size limit before body buffering
- ghostwright#4: Replace Date.now() with crypto.randomUUID() for unique IDs
- ghostwright#7: Fix JSON unwrap logic for ActivityStreams Note objects
- ghostwright#11: Replace 'Error:' text sniffing with runtime error events

Logic and security fixes:
- ghostwright#3: Fix msgId/msg name collision in error handling
- ghostwright#5: Improve parseConversationId to handle colons in tokens
- ghostwright#6: Reject webhooks without target.id instead of silent fallback
- ghostwright#8: Normalize emoji to avoid variation selector validation issues
- ghostwright#9: Handle 404/409 reaction responses as success conditions
- ghostwright#10: Make setReaction return boolean for proper error handling
- ghostwright#12: Improve bot loop guard with actorId checking

Best practices and polish:
- ghostwright#13: Make port configurable instead of hardcoded 3200
- ghostwright#14: Move webhookPath default normalization to constructor
- ghostwright#15: Fix health check path precedence (check webhook first)
- ghostwright#16: Add exponential backoff retry for 5xx/429 responses
- ghostwright#17: Add URL validation and encoding for talkServer config
- ghostwright#18: Document HMAC signing asymmetry (inbound vs outbound)
- ghostwright#20: Import randomUUID explicitly from node:crypto
- ghostwright#21: Add reactions: true to channel capabilities
- ghostwright#22: Namespace environment variables with NEXTCLOUD_ prefix

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants